ajar-state: boolean vs. byte

[svn42.git] / firmware / tuer.pde

diff --git a/firmware/tuer.pde b/firmware/tuer.pde
index 10efc92..3813e00 100644 (file)
--- a/firmware/tuer.pde
+++ b/firmware/tuer.pde
@@ -21,8 +21,9 @@ byte next_led = 0;
 #define LIMIT_CLOSED_PIN 19 // A5: limit switch for close
 
 #define AJAR_PIN 14 // input pin for reed relais (door ajar/shut)
-boolean ajar_last_state = false;
-boolean ajar_state_changed = false;
+#define SHUT 0
+#define AJAR 1
+byte ajar_last_state = SHUT;
 
 #define MANUAL_OPEN_PIN 12  // keys for manual open and close
 #define MANUAL_CLOSE_PIN 13 // 
@@ -81,19 +82,19 @@ boolean is_closed()
 
 //**********//
 
-void init_ajar()
+byte get_ajar_status()
 {
-  pinMode(AJAR_PIN, INPUT);      // set pin to input
-  digitalWrite(AJAR_PIN, HIGH);  // turn on pullup resistors  
-  ajar_last_state = digitalRead(AJAR_PIN);
+  if(digitalRead(AJAR_PIN) == LOW)
+    return SHUT;
+  
+  return AJAR;
 }
 
-boolean get_ajar_status()  // shut = true, ajar = false
+void init_ajar()
 {
-  if(digitalRead(AJAR_PIN))
-     return false;
-     
-  return true;
+  pinMode(AJAR_PIN, INPUT);      // set pin to input
+  digitalWrite(AJAR_PIN, HIGH);  // turn on pullup resistors  
+  ajar_last_state = get_ajar_status();
 }
 
 //**********//
@@ -391,7 +392,7 @@ ISR(TIMER1_COMPA_vect)
     else if(is_closed())
       Serial.print("closed");
     Serial.print(", idle");
-    if(get_ajar_status())
+    if(get_ajar_status() == SHUT)
       Serial.println(", shut");
     else
       Serial.println(", ajar");
@@ -461,19 +462,12 @@ void init_heartbeat()
 // while running this gets called every ~10ms
 ISR(TIMER2_COMPA_vect)
 {
-  boolean a = get_ajar_status();
   heartbeat_cnt++;
-  if(heartbeat_cnt == HEARTBEAT_DURATION) {
+  if(heartbeat_cnt == HEARTBEAT_DURATION)
     heartbeat_off();
-    if(a != ajar_last_state) 
-      ajar_state_changed = true;
-    ajar_last_state = a;
-  } else if(heartbeat_cnt >= HEARTBEAT_DELAY) {
+  else if(heartbeat_cnt >= HEARTBEAT_DELAY) {
     heartbeat_on();
     heartbeat_cnt = 0;
-    if(a != ajar_last_state)
-      ajar_state_changed = true;
-    ajar_last_state = a;
   }
 }
 
@@ -531,7 +525,7 @@ void print_status()
   case WAIT: Serial.print(", waiting"); break;
   default: Serial.print(", <undefined state>"); break;
   }
-  if(get_ajar_status())
+  if(get_ajar_status() == SHUT)
     Serial.println(", shut");
   else
     Serial.println(", ajar");
@@ -631,8 +625,10 @@ void loop()
       PORTD = LEDS_ON;
     }
   }
-  if(ajar_state_changed) {
-    ajar_state_changed = false;
+  byte a = get_ajar_status();
+  if(a != ajar_last_state)
+  {
     print_status();
+    ajar_last_state = a;
   }
 }