X-Git-Url: https://git.realraum.at/?p=svn42.git;a=blobdiff_plain;f=door_daemon%2Fdoor_daemon.c;h=bddb28fc371209019d2a80421d47bed46718db1f;hp=4288baf7273d7923d1c0e6629fdcf56b208b60de;hb=4ee2501ff864b8e15202ee814e8bafcc0c2adf6c;hpb=5ca67789bea6461f6fedb0b9a80a372b8012fdc2

diff --git a/door_daemon/door_daemon.c b/door_daemon/door_daemon.c
index 4288baf..bddb28f 100644
--- a/door_daemon/door_daemon.c
+++ b/door_daemon/door_daemon.c
@@ -6,8 +6,9 @@
  *  This file is part of door_daemon.
  *
  *  door_daemon is free software: you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 3 as
- *  published by the Free Software Foundation.
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation, either version 3 of the License, or
+ *  any later version.
  *
  *  door_daemon is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -38,7 +39,6 @@
 #include "client_list.h"
 
 #include "daemon.h"
-#include "sysexec.h"
 
 int init_command_socket(const char* path)
 {
@@ -50,7 +50,11 @@ int init_command_socket(const char* path)
 
   struct sockaddr_un local;
   local.sun_family = AF_UNIX;
-  strcpy(local.sun_path, path); // TODO: strlen ???
+  if(sizeof(local.sun_path) <= strlen(path)) {
+    log_printf(ERROR, "socket path is to long (max %d)", sizeof(local.sun_path)-1);
+    return -1;
+  }
+  strcpy(local.sun_path, path);
   unlink(local.sun_path);
   int len = SUN_LEN(&local);
   int ret = bind(fd, (struct sockaddr*)&local, len);
@@ -91,7 +95,7 @@ int send_command(int door_fd, cmd_t* cmd)
   } while(!ret || (ret == -1 && errno == EINTR));
 
   if(ret > 0) {
-    cmd->sent = 1;
+    cmd_sent(cmd);
     return 0;
   }
 
@@ -107,7 +111,7 @@ int send_response(int fd, const char* response)
   int offset = 0;
   int ret;
   for(;;) {
-    ret = write(fd, &response[offset], strlen(response));
+    ret = write(fd, &response[offset], len - offset);
     if(ret < 0) {
       if(errno != EINTR)
         return ret;
@@ -129,8 +133,10 @@ int send_response(int fd, const char* response)
   return ret;
 }
 
-int handle_command(const char* cmd, int fd, cmd_t** cmd_q, client_t* client_lst)
+int process_cmd(const char* cmd, int fd, cmd_t **cmd_q, client_t* client_lst)
 {
+  log_printf(DEBUG, "processing command from %d", fd);
+
   if(!cmd_q || !cmd)
     return -1;
   
@@ -148,24 +154,35 @@ int handle_command(const char* cmd, int fd, cmd_t** cmd_q, client_t* client_lst)
   else if(!strncmp(cmd, "log", 3))
     cmd_id = LOG;
   else if(!strncmp(cmd, "listen", 6)) {
-    client_t* listener = client_find(client_lst, fd);
-    if(listener) {
-      log_printf(DEBUG, "adding status listener %d", fd);
-      listener->status_listener = 1;
-    }
-    else       
-      log_printf(ERROR, "unable to add status listener %d", fd);
-
-    return 0;
+    cmd_id = LISTEN;
   }
   else {
     log_printf(WARNING, "unknown command '%s'", cmd);
-    return 1;
+    return 0;
   }
   char* param = strchr(cmd, ' ');
   if(param) 
     param++;
 
+  if(cmd_id == OPEN || cmd_id == CLOSE || cmd_id == TOGGLE) {
+    char* resp;
+    asprintf(&resp, "Request: %s", cmd);
+    if(resp) {
+      char* linefeed = strchr(resp, '\n');
+      if(linefeed) linefeed[0] = 0;
+      client_t* client;
+      int listener_cnt = 0;
+      for(client = client_lst; client; client = client->next)
+        if(client->request_listener && client->fd != fd) {
+          send_response(client->fd, resp);
+          listener_cnt++;
+        }
+      free(resp);
+      log_printf(DEBUG, "sent request to %d additional listeners", listener_cnt);
+    }
+// else silently ignore memory alloc error
+  }
+
   switch(cmd_id) {
   case OPEN:
   case CLOSE:
@@ -186,86 +203,148 @@ int handle_command(const char* cmd, int fd, cmd_t** cmd_q, client_t* client_lst)
       log_printf(DEBUG, "ignoring empty ext log message");
     break;
   }
+  case LISTEN: {
+    client_t* listener = client_find(client_lst, fd);
+    if(listener) {
+      if(!param) {
+        listener->status_listener = 1;
+        listener->error_listener = 1;      
+        listener->request_listener = 1;
+      }
+      else {
+        if(!strncmp(param, "status", 6))
+          listener->status_listener = 1;
+        else if(!strncmp(param, "error", 5))
+          listener->error_listener = 1;      
+        else if(!strncmp(param, "request", 7))
+          listener->request_listener = 1;
+        else {
+          log_printf(DEBUG, "unkown listener type '%s'", param);
+          break;
+        }
+      }
+      log_printf(DEBUG, "listener %d requests %s messages", fd, param ? param:"all");
+    }
+    else {
+      log_printf(ERROR, "unable to add listener %d", fd);
+    }
+    break;
+  }
   }
   
   return 0;
 }
 
-int process_cmd(int fd, cmd_t **cmd_q, client_t* client_lst)
+int nonblock_recvline(read_buffer_t* buffer, int fd, cmd_t** cmd_q, client_t* client_lst)
 {
-  log_printf(DEBUG, "processing command from %d", fd);
-
-  static char buffer[100];
   int ret = 0;
-  do { // TODO: replace this whith a actually working readline
-    memset(buffer, 0, 100);
-    ret = recv(fd, buffer, sizeof(buffer), 0);
+  for(;;) {
+    ret = recv(fd, &buffer->buf[buffer->offset], 1, 0);
     if(!ret)
-      return 1;
-    if(ret < 0)
-      return ret;
+      return 2;
+    if(ret == -1 && errno == EAGAIN)
+      return 0;
+    else if(ret < 0)
+      break;
 
-    char* saveptr;
-    char* tok = strtok_r(buffer, "\n\r", &saveptr);
-    do {
-      if(!tok)
-        continue;
+    if(buffer->buf[buffer->offset] == '\n') {
+      buffer->buf[buffer->offset] = 0;
+      ret = process_cmd(buffer->buf, fd, cmd_q, client_lst);
+      buffer->offset = 0;
+      break;
+    }
 
-      ret = handle_command(tok, fd, cmd_q, client_lst);
-      if(ret < 0)
-        return ret;
-    } while(tok = strtok_r(NULL, "\n\r", &saveptr));
-  } while (ret == -1 && errno == EINTR);
-    
-  return 0;
+    buffer->offset++;
+    if(buffer->offset >= sizeof(buffer->buf)) {
+      log_printf(DEBUG, "string too long (fd=%d)", fd);
+      buffer->offset = 0;
+      return 0;
+    }
+  }
+
+  return ret;
 }
 
-int process_door(int door_fd, cmd_t **cmd_q, client_t* client_lst)
+int process_door(read_buffer_t* buffer, int door_fd, cmd_t **cmd_q, client_t* client_lst)
 {
-  log_printf(DEBUG, "processing data from door (fd=%d)", door_fd);
-
-  static char buffer[100];
   int ret = 0;
-  do { // TODO: replace this whith a actually working readline
-    memset(buffer, 0, 100);
-    ret = read(door_fd, buffer, sizeof(buffer));
-    if(!ret) 
-      return 2;
-    if(ret < 0)
+  struct timeval tv;
+  fd_set fds;
+  FD_ZERO(&fds);
+  FD_SET(door_fd, &fds);
+
+  for(;;) {
+    tv.tv_sec = 0;
+    tv.tv_usec = 0;
+    ret = select(door_fd+1, &fds, NULL, NULL, &tv);
+    if(!ret)
+      return 0;
+    else if(ret < 0)
       return ret;
 
-    char* saveptr;
-    char* tok = strtok_r(buffer, "\n\r", &saveptr);
-    do {
-      if(!tok)
-        continue;
+    ret = read(door_fd, &buffer->buf[buffer->offset], 1);
+    if(!ret)
+      return 2;
+    if(ret == -1 && errno == EAGAIN)
+      return 0;
+    else if(ret < 0)
+      break;
 
-      log_printf(NOTICE, "door-firmware: %s", tok);
+    if(buffer->buf[buffer->offset] == '\n') {
+      buffer->buf[buffer->offset] = 0;
+
+      if(buffer->offset > 0 && buffer->buf[buffer->offset-1] == '\r')
+        buffer->buf[buffer->offset-1] = 0;
+
+      log_printf(NOTICE, "door-firmware: %s", buffer->buf);      
 
       int cmd_fd = -1;
       if(cmd_q && (*cmd_q)) {
         cmd_fd = (*cmd_q)->fd;
-        send_response(cmd_fd, tok);
+        send_response(cmd_fd, buffer->buf);
       }
-
-      if(!strncmp(tok, "Status:", 7)) {
+      
+      if(!strncmp(buffer->buf, "Status:", 7)) {
         client_t* client;
+        int listener_cnt = 0;
         for(client = client_lst; client; client = client->next)
-          if(client->status_listener && client->fd != cmd_fd)
-            send_response(client->fd, tok);
+          if(client->status_listener && client->fd != cmd_fd) {
+            send_response(client->fd, buffer->buf);
+            listener_cnt++;
+          }
+        log_printf(DEBUG, "sent status to %d additional listeners", listener_cnt);
       }
 
+      if(!strncmp(buffer->buf, "Error:", 6)) {
+        client_t* client;
+        int listener_cnt = 0;
+        for(client = client_lst; client; client = client->next)
+          if(client->error_listener && client->fd != cmd_fd) {
+            send_response(client->fd, buffer->buf);
+            listener_cnt++;
+          }
+        log_printf(DEBUG, "sent error to %d additional listeners", listener_cnt);
+      }
+      
       cmd_pop(cmd_q);
-    } while(tok = strtok_r(NULL, "\n\r", &saveptr));
-  } while (ret == -1 && errno == EINTR);
+      buffer->offset = 0;
+      return 0;
+    }
 
-  return 0;
-}
+    buffer->offset++;
+    if(buffer->offset >= sizeof(buffer->buf)) {
+      log_printf(DEBUG, "string too long (fd=%d)", door_fd);
+      buffer->offset = 0;
+      return 0;
+    }
+  }
 
+  return ret;
+}
 
 int main_loop(int door_fd, int cmd_listen_fd)
 {
-  log_printf(INFO, "entering main loop");
+  log_printf(NOTICE, "entering main loop");
 
   fd_set readfds, tmpfds;
   FD_ZERO(&readfds);
@@ -275,32 +354,48 @@ int main_loop(int door_fd, int cmd_listen_fd)
   cmd_t* cmd_q = NULL;
   client_t* client_lst = NULL;
 
+  read_buffer_t door_buffer;
+  door_buffer.offset = 0;
+
   int sig_fd = signal_init();
   if(sig_fd < 0)
     return -1;
   FD_SET(sig_fd, &readfds);
   max_fd = (max_fd < sig_fd) ? sig_fd : max_fd;
 
+  struct timeval timeout;
   int return_value = 0;
   while(!return_value) {
     memcpy(&tmpfds, &readfds, sizeof(tmpfds));
 
-    int ret = select(max_fd+1, &tmpfds, NULL, NULL, NULL);
+    timeout.tv_sec = 0;
+    timeout.tv_usec = 200000;
+    int ret = select(max_fd+1, &tmpfds, NULL, NULL, &timeout);
     if(ret == -1 && errno != EINTR) {
       log_printf(ERROR, "select returned with error: %s", strerror(errno));
       return_value = -1;
       break;
     }
-    if(!ret || ret == -1)
+    if(ret == -1)
       continue;
-
-    if(signal_handle()) {
-      return_value = 1;
-      break;
+    if(!ret) {
+      if(cmd_q && cmd_has_expired(*cmd_q)) {
+        log_printf(ERROR, "last command expired");
+        cmd_pop(&cmd_q);
+      }
+      else
+        continue;
     }
 
+    if(FD_ISSET(sig_fd, &tmpfds)) {
+      if(signal_handle()) {
+        return_value = 1;
+        break;
+      }
+    }
+   
     if(FD_ISSET(door_fd, &tmpfds)) {
-      return_value = process_door(door_fd, &cmd_q, client_lst);
+      return_value = process_door(&door_buffer, door_fd, &cmd_q, client_lst);
       if(return_value)
         break;
     }
@@ -315,14 +410,15 @@ int main_loop(int door_fd, int cmd_listen_fd)
       log_printf(DEBUG, "new command connection (fd=%d)", new_fd);
       FD_SET(new_fd, &readfds);
       max_fd = (max_fd < new_fd) ? new_fd : max_fd;
+      fcntl(new_fd, F_SETFL, O_NONBLOCK);
       client_add(&client_lst, new_fd);
     }
 
     client_t* lst = client_lst;
     while(lst) {
       if(FD_ISSET(lst->fd, &tmpfds)) {
-        return_value = process_cmd(lst->fd, &cmd_q, client_lst); 
-        if(return_value == 1) {
+        return_value = nonblock_recvline(&(lst->buffer), lst->fd, &cmd_q, client_lst);
+        if(return_value == 2) {
           log_printf(DEBUG, "removing closed command connection (fd=%d)", lst->fd);
           client_t* deletee = lst;
           lst = lst->next;
@@ -335,7 +431,8 @@ int main_loop(int door_fd, int cmd_listen_fd)
           break;
 
       }
-      lst = lst->next;
+      if(lst)
+        lst = lst->next;
     }
 
     if(cmd_q && !cmd_q->sent)